Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.0.0 #35

Merged
merged 58 commits into from Dec 23, 2021
Merged

Release/1.0.0 #35

merged 58 commits into from Dec 23, 2021

Conversation

williamrolando88
Copy link
Owner

@williamrolando88 williamrolando88 commented Dec 23, 2021

Hi, in this PR we release the first version of Ultimate Show Guide which has the following functionalities:

  • Fetch data from an external API
  • Show the data on a home page
  • Let you click on the like button and keep track of that information
  • Let you open a comments window with extended information about the selected TV series
  • Add comments to the selected TV series
  • Keep track of the comments submitted

Please find our project presentation video on vimeo

Copy link

@elisha2kyakpo1 elisha2kyakpo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

Great job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:
-n/a
Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

old_scripts/popUp.js Outdated Show resolved Hide resolved
old_scripts/popUp.js Outdated Show resolved Hide resolved
old_scripts/popUp.js Outdated Show resolved Hide resolved
Copy link

@HillaryOkello HillaryOkello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @williamrolando88 and @Anjacodes,

To highlight

  • Descriptive pull request ✅
  • Descriptive README file ✅
  • Clean code ✅

Nice work implementing the changes suggested by the previous reviewer 👏🏻
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉. Keep up the good work 💪🏻

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Anjacodes Anjacodes merged commit 49ca1c0 into main Dec 23, 2021
@Anjacodes Anjacodes deleted the release/1.0.0 branch December 23, 2021 22:34
@williamrolando88 williamrolando88 restored the release/1.0.0 branch December 23, 2021 22:36
@williamrolando88 williamrolando88 deleted the release/1.0.0 branch December 23, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants