Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll optimization #1524

Merged
merged 10 commits into from Jan 9, 2023
Merged

Scroll optimization #1524

merged 10 commits into from Jan 9, 2023

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Jan 8, 2023 •
edited

  • Calculates resized widgets more efficiently
  • Added Widget._refresh_scroll to scroll without expensive layout operation
  • Potentially reduced needless repaints
  • Various micro-optimizations

@willmcgugan willmcgugan marked this pull request as draft January 8, 2023 16:25
@willmcgugan willmcgugan marked this pull request as ready for review January 8, 2023 16:53
@willmcgugan willmcgugan merged commit 73fcbdc into main Jan 9, 2023
@willmcgugan willmcgugan deleted the scroll-optimization branch January 9, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenburns darrenburns darrenburns approved these changes

@davep davep Awaiting requested review from davep

@rodrigogiraoserrao rodrigogiraoserrao Awaiting requested review from rodrigogiraoserrao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willmcgugan @darrenburns