ngAcceptInputType_animation is too permissive

[rafaelss95]

I'm submitting a ... (check one with "x")

• bug report => search github for a similar issue or PR before submitting
• feature request

Current behavior
Since 2.8.0 we can pass to animation something like true or any string and the template won't fail (even under strict mode). It happens because actually ngAcceptInputType_animation masks the real type, as it is too permissive:

ngx-skeleton-loader/projects/ngx-skeleton-loader/src/lib/ngx-skeleton-loader.component.ts

Line 24 in 2bd255c

static ngAcceptInputType_animation: boolean | string;

The allowed types are:

ngx-skeleton-loader/projects/ngx-skeleton-loader/src/lib/ngx-skeleton-loader.component.ts

Lines 35 to 36 in 2bd255c

	@Input()
	animation: 'progress' | 'progress-dark' | 'pulse' | 'false' | false = 'progress';

---

Expected behavior
Unless I'm missing something the ngAcceptInputType_animation doesn't seem to help in anything there and thus can be safely removed.

Reproduction of the problem
https://stackblitz.com/edit/angular-ivy-b34arq

Please tell us about your environment:

• Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX |
  Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

• Language: [all | TypeScript X.X | ES6/7 | ES5]
  Angular 11, ngx-skeleton-loader 2.9.0.

[willmendesneto]

The dev mode message was added to describe that behaviour. Also, Angular Universal complains about don't have a boolean expressely added, so its required.

The type was updated to

Since it's not a problem and it's covered, I'm closing this issue. Thanks again for raising that!

[rafaelss95]

Also, Angular Universal complains about don't have a boolean expressely added, so its required.

Aha, I didn't know that part, thanks for the info.