feat!: support for more highlight attrs #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: use Lua api to create hlgroups
willothy
changed the title
Problem: calls to highlight group functions are called almost constantly, possibly affecting performance. Solution: cache results of the calls, significantly reducing the number of API calls required for redraw.
willothy
force-pushed
the
hl-refactor
branch
5 times, most recently
from
8911edc
to
04f5d6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #147
This is a breaking change as the config for highlighting is slightly different. Instead of using a "style" property, individual properties such as
boldorunderlineare set via[name] = boolean, or[name] = fun(cx):boolean, the same way thatfg,bg, andspare set.