Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make state publicly available? #11

Closed
mattyohe opened this issue Aug 16, 2016 · 3 comments
Closed

Make state publicly available? #11

mattyohe opened this issue Aug 16, 2016 · 3 comments
Labels

Comments

@mattyohe
Copy link
Collaborator

mattyohe commented Aug 16, 2016

https://github.com/willowtreeapps/cordux/blob/develop/Sources/Store.swift#L24

Is there a reason that Store's state is not publicly accessible?

@mattyohe
Copy link
Collaborator Author

mattyohe commented Aug 16, 2016

More specifically: State being available only to read not set. So:

public private (set) var state: State

@mattyohe
Copy link
Collaborator Author

Hmm, we'd have to protect reading/writing access however...

@ianterrell
Copy link
Contributor

The intention was to have a single point of access for reading (subscriptions) and for writing (reducers). But the latter is significantly more important than the former. I can't think of a good reason to deny public read access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants