Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] typeOf item != ‘function’ missing as a native support check #23

Closed
willstocks opened this issue Feb 18, 2019 · 1 comment · Fixed by #28
Closed

[Feature Request] typeOf item != ‘function’ missing as a native support check #23

willstocks opened this issue Feb 18, 2019 · 1 comment · Fixed by #28
Labels
bug Something isn't working feature request Functionality that doesn't currently exist, but could/should! Good first issue This is a good starting point. Get involved - give these ones a go!
Milestone
v0.0.8

Comments

@willstocks
Copy link
Owner

willstocks commented Feb 18, 2019 •
edited

Noticed this as Object.assign was being polyfilled in Chrome despite it having native support.
@willstocks willstocks self-assigned this Feb 18, 2019
@willstocks willstocks added bug Something isn't working Good first issue This is a good starting point. Get involved - give these ones a go! labels Feb 18, 2019
@willstocks willstocks modified the milestones: v0.06, v0.0.6, v0.0.7 Feb 18, 2019
@willstocks
Copy link
Owner Author

Punting to 0.0.7 - need to validate whether this is a legit requirement or not...

Fixing the if's in checking() has resolved the issue of Object.assign in Chrome - it was false positiving on one of the statements that has now been split out into a nested if and only fires for browsers that need it now - therefore at the moment all existing checks look "OK"

@willstocks willstocks added the feature request Functionality that doesn't currently exist, but could/should! label Feb 20, 2019
@willstocks willstocks changed the title [Bug] typeOf item != ‘function’ missing as a native support check [Feature Request] typeOf item != ‘function’ missing as a native support check Feb 20, 2019
@willstocks willstocks removed their assignment Feb 20, 2019
@willstocks willstocks modified the milestones: v0.0.7, v0.0.8 Feb 25, 2019
This was referenced Mar 12, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working feature request Functionality that doesn't currently exist, but could/should! Good first issue This is a good starting point. Get involved - give these ones a go!
Projects
None yet
Milestone
v0.0.8
Development

Successfully merging a pull request may close this issue.

v0.0.8 willstocks/dynamically-polyfill-features-for-a-script
1 participant
@willstocks