Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid multiple computation of sum(Y^2) #118

Closed
YushaLiu opened this issue Apr 9, 2024 · 1 comment
Closed

Avoid multiple computation of sum(Y^2) #118

YushaLiu opened this issue Apr 9, 2024 · 1 comment

Comments

@YushaLiu
Copy link

YushaLiu commented Apr 9, 2024

sum(Y^2) gets recomputed every time flash_update_data() is called. This is wasteful when only the diagonal changes. Add an argument to flash_update_data to prevent this, say Y2_diff.
@willwerscheid
Copy link
Owner

this has now been implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willwerscheid @YushaLiu