Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish-shell not working #36

Closed
denji opened this issue Mar 6, 2014 · 7 comments
Closed

fish-shell not working #36

denji opened this issue Mar 6, 2014 · 7 comments

Comments

@denji
Copy link

denji commented Mar 6, 2014

fishShell: https://github.com/fish-shell/fish-shell/
oh-my-fish: https://github.com/bpinto/oh-my-fish

~/.config/fish/config.fish

. $(brew --prefix php-version)/php-version.sh
fish: Illegal command name 'COLOR_NORMAL=$(tput sgr0)'
/usr/local/Cellar/php-version/0.10.4/php-version.sh (line 10):   COLOR_NORMAL=$(tput sgr0)
                                                                 ^
in . (source) call of file '/usr/local/Cellar/php-version/0.10.4/php-version.sh',
    called on standard input,

fish: Illegal command name 'COLOR_REVERSE=$(tput smso)'
/usr/local/Cellar/php-version/0.10.4/php-version.sh (line 11):   COLOR_REVERSE=$(tput smso)
                                                                 ^
in . (source) call of file '/usr/local/Cellar/php-version/0.10.4/php-version.sh',
    called on standard input,

fish: Illegal command name '[[ -n $(command -v brew) ]]'
/usr/local/Cellar/php-version/0.10.4/php-version.sh (line 25):   if [[ -n $(command -v brew) ]]; then
                                                                    ^
in . (source) call of file '/usr/local/Cellar/php-version/0.10.4/php-version.sh',
    called on standard input,
@wilmoore
Copy link
Owner

wilmoore commented Mar 6, 2014

I probably should note this on the readme, but I don't officially support shells other than bash and zsh. That being said, I'd be happy to take a PR; otherwise, this will be on hold until I have the desire to support the fish shell.

OTOH, I will likely re-write this soon in go, then it's a moot point as it should work just about anywhere.

@corysimmons
Copy link

Rewrite in Go so works everywhere pls. 💯

@wilmoore
Copy link
Owner

wilmoore commented Dec 7, 2016

After evaluating go-lang I've decided I have no long-term interest in that language. If I re-write this, it will likely be done with rust.

@wilmoore
Copy link
Owner

wilmoore commented Dec 7, 2016

SEE: #56

@corysimmons
Copy link

I keep hearing people like Rust. I should probably read about it.

I ended up going with phpbrew out of impatience, but this might be a good project to play around with Rust (assuming you aren't already a master of it). :}

@wilmoore
Copy link
Owner

wilmoore commented Dec 7, 2016

The more important bit of info is that I haven't done PHP work in several years and I don't plan to change that. That being said, php-version is a simple program and I do like solving these types of problem so I'll likely get around to it at some point.

@corysimmons
Copy link

Yeah, I feel ya. I wish I could live in ES6+ Node forever but WordPress gonna WordPress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants