Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

count past zero causes errors #14

Closed
sygad opened this issue Feb 4, 2014 · 3 comments
Closed

count past zero causes errors #14

sygad opened this issue Feb 4, 2014 · 3 comments

Comments

@sygad
Copy link

sygad commented Feb 4, 2014

Hi,

Lovely plugin, but I have 2 problems if you can offer any help.

I've set "count_past_zero" to false but it causes errors:

Line 273:
uncaught reference error: time is not defined

When I set days, hours, and minutes to false, the second counter no longer shows the foreground color.

Im using Win7 and i've tested on Chrome, IE11 and Firefox


$("#CountDownTimer").TimeCircles({
start: true, // determines whether or not TimeCircles should start immediately.
refresh_interval: 0.1, // determines how frequently TimeCircles is updated.
count_past_zero: false, // This option is only really useful for when counting down. What it does is either give you the option to stop the timer, or start counting up after you've hit the predefined date (or your stopwatch hits zero).
circle_bg_color: "#60686F", // determines the color of the background circle.
use_background: true, // sets whether any background circle should be drawn at all.
fg_width: 0.1, // sets the width of the foreground circle.
bg_width: 1.2, // sets the width of the backgroundground circle.
time: { // a group of options that allows you to control the options of each time unit independently.
Days: {
show: false,
text: "Days",
color: "#FC6"
},
Hours: {
show: false,
text: "Hours",
color: "#9CF"
},
Minutes: {
show: false,
text: "Minutes",
color: "#BFB"
},
Seconds: {
show: true,
text: "Seconds",
color: "#BFB"
}
}
});

@wimbarelds
Copy link
Owner

Thanks for the report, I have determined the cause for both of these problems and am working on them now. The first of them I have fixed, the second one... Technically it is showing, but it's showing at the size that it would be if full circle is a full year. So, basically it's always at 0.0000000000001 degrees. I'm fixing it now.

@wimbarelds
Copy link
Owner

Please have a look at https://github.com/wimbarelds/TimeCircles/releases/tag/1.1.4

This should fix your problem.

@sygad
Copy link
Author

sygad commented Feb 5, 2014

Thanks for responding so quickly and fixing this issue. Very much appreaciated.

The new feature, total duration is brilliant, I was going to ask that as a feature request.

Can't wait to tell the rest of my company about this plugin

@sygad sygad closed this as completed Feb 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants