Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE and IndexOf #38

Closed
joviberton opened this issue Apr 22, 2014 · 2 comments
Closed

IE and IndexOf #38

joviberton opened this issue Apr 22, 2014 · 2 comments

Comments

@joviberton
Copy link

on ie8 in timecircles.js line line 352 , there's "indexOf" that's not recognised as known on issue documented on some articles online as
http://stackoverflow.com/questions/3629183/why-doesnt-indexof-work-on-an-array-ie8

which provides also a quick fix.

should be nice to have a workaround for canvas on IE8 maybe using 'explorercanvas'

kudos

@wimbarelds
Copy link
Owner

Hi there,

Thanks for the heads up!

I've recently added something on the TimeCircles demo page that should automatically log any errors that anyone runs into- which will help on picking up on things like this. This one specifically however had not yet come past.

I'll likely implement the fix as suggested on the stackoverflow page for the .indexOf(... issue. I will not package explorercanvas with timecircles, however I might include a reference for it somewhere in the documentation.

Unfortunately I don't really have a lot of free time at this point, so I'm not sure when these things will happen.

@wimbarelds
Copy link
Owner

Hi again, the latest version of TimeCircles now has support for explorercanvas and has a fallback for Array.indexOf. For explorercavas all you have to do is include excanvas.js. TimeCircles will detect and make use of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants