Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand SAN certificates? #189

Closed
lpkant opened this issue Apr 8, 2016 · 9 comments
Closed

Expand SAN certificates? #189

lpkant opened this issue Apr 8, 2016 · 9 comments

Comments

@lpkant
Copy link

lpkant commented Apr 8, 2016

Hi @lone-coder,
thanks for developing such an useful application!! :-)

I got a question though - we happen to have multiple domains in one certificate and add new domains once in a while (~1-2 a month).
Currently, as it is my understanding, if you use --san (manual mode) you are issuing a complete new certificate whenever you want to extend it. Therefore the existant certifcate remains as well and at expiry time you get warning mails von LE...

Is there a way to expand the certificate and let it replace the old one?

I found an option (--expand) in the official documentation - but it looks like that there is no reference in your code or in @ebekker ACMESharp as well ...
http://letsencrypt.readthedocs.org/en/latest/man/letsencrypt.html?highlight=expand

Thanks for helping or giving some advice! :-)

Regards lpk

@rkerber
Copy link
Collaborator

rkerber commented Apr 8, 2016

Until it's supported in ACMESharp, there is really nothing we can do.

@Trumf-dk
Copy link

I think this will be possible when Revocation has been implemented in ACMESharp. It is set for the milestone 0.8.5 ebekker/ACMESharp#103
My problem is that I have too many certificates for the same domain and need to have some to "time out" renewals so I can make SAN's instead.
I'm testing a new plugin for deleteing renewals and hope to upload it later today. This will only be a temporary solution though...

Regards Trumf

@rkerber
Copy link
Collaborator

rkerber commented Apr 10, 2016

@Trumf-dk, the renewal system is going to be completely rewritten soon to not use the registry, so take that into account when working on your plugin.

@Trumf-dk
Copy link

I need this function and can't wait so I will rewrite it when it is done. It would be nice to have a roadmap so it will be easier to plan things like this. I have thought of rewriting to use central store as well and will start when another plugin I need is done...

@rkerber
Copy link
Collaborator

rkerber commented Apr 10, 2016

Linking to Revocation enhancement request #78

@WouterTinus
Copy link
Member

WouterTinus commented Aug 23, 2017

v1.9.5 will support this by re-scanning the bindings of IIS websites before renewal, but I just realised that the older certificate will still expire. I will have to check out how hard it would be to revoke the older certificate on such changes.

@WouterTinus WouterTinus modified the milestone: v1.9.5 Aug 23, 2017
@WouterTinus WouterTinus removed this from the v1.9.5 milestone Sep 4, 2017
@WouterTinus
Copy link
Member

I want to make this a bit more clear so we get it right.

  • Let's say you have set up a SAN certificate for a.example.com and b.example.com
  • You add a binding to IIS, c.example.com
  • You run WACS, it detects the new binding
  • It requests a new SAN certificate for a.example.com, b.example.com and c.example.com

Now, after some weeks, Let's Encrypt will start warning you that your [a-b] certificate is going to expire, while you don't need it anymore. Is the correct way to prevent that to revoke the certificate? Or is there another way to tell the ACME server that we stopped caring?

I couldn't find one in the protocol, but a revoke seems a bit harsh, implying a security breach and unnecessarily adding to the CRL.

@cpu?

@cpu
Copy link

cpu commented Feb 26, 2018

Hi @WouterTinus,

Is the correct way to prevent that to revoke the certificate?

Revocation is not recommended by Let's Encrypt except for key compromise.

Or is there another way to tell the ACME server that we stopped caring?

There isn't a general way to tell the ACME server that you don't want expiration warnings for the now replaced certificate. ACME has no notion of expiration warnings at all, that's a Let's Encrypt specific feature. You could unsubscribe from the expiration warnings via the link in the email (or delete your ACME account contact) but this will have the effect of silencing all expiration warnings, not just those for a specific certificate. We have some open issues related to this (letsencrypt/boulder#2475, letsencrypt/boulder#1396) but unfortunately they require us to stand up a whole new service in front of our mail provider's API and its a fair bit of work blocked by higher priority items.

@WouterTinus
Copy link
Member

Thanks for your insight @cpu! Then we'll keep this open just in case those issues get resolved sometime in the future, but we definitely won't do the revoke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants