Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindTurbineCluster takes only WindFarms but not WindTurbines #70

Open
uvchik opened this issue Aug 27, 2019 · 4 comments · May be fixed by #102
Open

WindTurbineCluster takes only WindFarms but not WindTurbines #70

uvchik opened this issue Aug 27, 2019 · 4 comments · May be fixed by #102
Assignees
Milestone

Comments

@uvchik
Copy link
Member

uvchik commented Aug 27, 2019

The input of the WindTurbineCluster is a list of WindFarm objects. WindTurbine objects are not allowed. I think we should either rename the class or allow WindTurbine objects or both.

@uvchik
Copy link
Member Author

uvchik commented Oct 21, 2019

What about WindFarmCluster?

@uvchik uvchik modified the milestones: v0.2.1, Developer meeting Nov 15, 2019
@SabineHaas
Copy link
Member

decision dev meeting:
Allow WindTurbines / WindTurbineGroups in WindTurbineCluster.

@uvchik uvchik modified the milestones: Developer meeting, v0.2.1 Feb 14, 2020
@uvchik
Copy link
Member Author

uvchik commented Feb 14, 2020

I have two ideas how to deal with the problem.

  1. We could convert all WindTurbines to WindFarms with just one Turbine. This is not very elegant but in my opinion the easiest way.
  2. We could make sure that all WindTurbines or WindTurbineGroups do have the same attributes needed in the cluster class and its methods. At some place we may have to distinguish between types. I think this is the better solution because we do not have to copy the object.

@uvchik uvchik linked a pull request Apr 7, 2020 that will close this issue
@SabineHaas
Copy link
Member

At the last dev meeting I promised to provide information for the second suggestion in your last comment. Here it is:

  • No problem with nominal power and hub height as they are attributes of both, wind farms and wind turbines
  • in assign_power_curve() in wind_turbine_cluster.py, where the power curve aggregation takes place, both, wind farm and wind turbine power curves could be aggregated but:
    • In this method an aggregated power curve is assigned for each wind farm in self.wind_farms here which does not work for wind turbines.

This "in-between" step of getting the aggregated wind farm power curves instead of just aggregating all wind turbine power curves (of all wind farms) was implemented like that to give the option of applying wake losses to wind farm power curves (of which each could have e.g. a different wind farm efficiency).

Options I see now to make WindTurbines possible in WindTurbineClusters.:

  1. Give WindTurbine the method assign_power_curve() which is just returning the power curve
  2. Differentiate here between WindTurbines and WindFarms

Other things I noticed:

  • **kwargs in WindTurbineCluster init is not used anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants