Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is "roughness_length" not a parameter in WindFarm.assign_power_curve()? #75

Open
uvchik opened this issue Sep 3, 2019 · 2 comments
Open

Why is "roughness_length" not a parameter in WindFarm.assign_power_curve()? #75

uvchik opened this issue Sep 3, 2019 · 2 comments
Assignees
@uvchik @birgits @SabineHaas
Labels
question
Milestone
v0.3.0

Comments

@uvchik
Copy link
Member

uvchik commented Sep 3, 2019 •
edited

In my opinion the way kwargs is used in this method is confusing. I think we should revise the concept. Or maybe I just do not understand it.
@uvchik uvchik added the question label Sep 3, 2019
@uvchik uvchik added this to the v0.2.1 milestone Sep 3, 2019
@birgits
Copy link
Member

birgits commented Feb 17, 2020

I think you are right, it is not really consistent and would be better, if we just made roughness_length a parameter as well.

@uvchik uvchik modified the milestones: v0.2.1, v0.3.0 Apr 7, 2020
@uvchik
Copy link
Member Author

uvchik commented Apr 7, 2020

This will have some more implications but I would like to discuss it on a developer meeting or a web conference. It is not urgent but we should not forget about it 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uvchik uvchik

@birgits birgits

@SabineHaas SabineHaas

Labels
question
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
3 participants
@uvchik @birgits @SabineHaas