Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with dxf2gcode exports #2258

Closed
timint opened this issue Jul 17, 2023 · 5 comments · Fixed by #2294
Closed

Incompatible with dxf2gcode exports #2258

timint opened this issue Jul 17, 2023 · 5 comments · Fixed by #2294

Comments

@timint
Copy link

timint commented Jul 17, 2023

Version

2.0.18

Hardware / Firmware

GRBL 1.1

What happened

Loaded a gcode file from dxf2gcode. UGS says coordinates are invalid because of whitespace after the axis letter.

How to reproduce

Produce a GCode file containing whitespace in coordinates after the axis letter. E.g. "X 10.00"

Operating System

Windows 11

Anything else

No response

@breiler
Copy link
Collaborator

breiler commented Jul 17, 2023

I just tried it with a sample file found online somewhere and the only place that I get errors are in the editor. Was this what you meant?

Screen Shot 2023-07-17 at 06 40 27

@timint
Copy link
Author

timint commented Jul 17, 2023

Yes. Thank you for providing a screen shot. I was on mobile.

I dunno if syntax can contain spaces or tabs also, and if GRBL itself would be ok with this. If yes, the editor should then validate something like this:
(X|Y|Z)(\t| )*[0-9]+(\.[0-9]+)?

@breiler
Copy link
Collaborator

breiler commented Jul 17, 2023

When using GRBL it will strip white spaces by default before sending it, so your regexp example should work just fine for viewing the gcode.

I'll make the adjustments to the parser, but that will take a couple of days since I am out of town.

Thanks for the bug report

@timint
Copy link
Author

timint commented Jul 17, 2023

No rush, I'm just happy to bring bones to the table. :)

@breiler
Copy link
Collaborator

breiler commented Aug 21, 2023

It should now be available in the latest nightly build here:
https://github.com/winder/Universal-G-Code-Sender#downloads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants