Add missing Transfer and Approval events #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the events in the *Data methods, and in burn
AugustoL
reviewed
Sep 29, 2017
|
Don't we want to have an event that includes the data param? Using the original events only has the downside that they don't include that value |
|
Yes, but the data parameter can be extracted from the transaction data, I think that will be better because if not we will log more information than the one we need. Lets just use the ERC20 token events. |
|
Makes sense, I'll change it that way |
TransferData and ApprovalData are not needed, we can just use the existing Transfer and Approval. The data content can be fetched from the transactions if needed
|
@AugustoL: just made the changes, how does it look now? |
AugustoL
approved these changes
Oct 3, 2017
|
Great, thanks @nberger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the events in the *Data methods, and in burn
Fixes #248