Refactor *Data methods in LifToken to use super methods #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AugustoL
reviewed
Oct 6, 2017
contracts/LifToken.sol
Outdated
| } | ||
|
|
||
| super.approve(spender, value); | ||
| assert(spender.call(data)); |
There was a problem hiding this comment.
I think here we should use require instead of assert.
There was a problem hiding this comment.
Agreed, I just changed it
|
Changes Unknown when pulling 8a590db on reuse-transfer-in-transfer-data into ** on master**. |
AugustoL
reviewed
Oct 9, 2017
contracts/LifToken.sol
Outdated
| } | ||
|
|
||
| super.transferFrom(from, to, value); | ||
| require(to.call(data)); |
There was a problem hiding this comment.
I think it should be first the require to save some gas, because if it fails later the gas used by transfer will be consumed.
There was a problem hiding this comment.
Agreed, just changed it in d818a37
AugustoL
approved these changes
Oct 9, 2017
The end result is the same. But this way it will be more natural to replace the first part of the methods with calls to the underlying methods transfer, transferFrom and approve
Calls super.approve, super.transfer & super.transferFrom from the corresponding *Data methods (approveData, transferData & transferDataFrom)
First do the contract call, then the approve/transfer. This way some gas is saved in case the call fails because the approve/transfer is not executed
nberger
force-pushed
the
reuse-transfer-in-transfer-data
branch
from
d818a37
to
b508102
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls super.approve, super.transfer & super.transferFrom from the corresponding
*Data methods (approveData, transferData & transferDataFrom)