Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Upgrade to Truffle 4.0.0 #298

Closed
wants to merge 2 commits into from
Closed

[WIP] Upgrade to Truffle 4.0.0 #298

wants to merge 2 commits into from

Conversation

nberger
Copy link
Contributor

@nberger nberger commented Oct 12, 2017

Upgrades to solc 0.4.17 and truffle 4.0.0-beta.2

But perhaps we should wait until the final truffle 4.0.0 is released before merging this

@AugustoL, @cgewecke: thoughts?

@nberger nberger requested a review from AugustoL October 12, 2017 20:07
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 98.792% when pulling 386a0c7 on truffle-4.0 into 86d8429 on master.

@cgewecke
Copy link
Contributor

@nberger Yeah! It works. Looks good.

There are a couple bugs at solidity-coverage we have to fix (today?) so that pure ,view and pragma experimental don't cause problems. But they only affect files imported from outside the contracts folder (pure, view) and yarn installations (pragma experimental).

@AugustoL
Copy link
Contributor

Lets continue using solc 0.4.15, we dont want to upgrade and change the contracts again.

@nberger
Copy link
Contributor Author

nberger commented Oct 13, 2017

Ok, closing now then, thanks!

@nberger nberger closed this Oct 13, 2017
@nberger nberger deleted the truffle-4.0 branch October 13, 2017 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants