Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App bugfix #1049

Merged
merged 11 commits into from Dec 29, 2022
Merged

App bugfix #1049

merged 11 commits into from Dec 29, 2022

Conversation

fatonramadani
Copy link
Contributor

@fatonramadani fatonramadani commented Dec 28, 2022 •
edited

Fix various bugs:

  • resizing any input make it take a single unit of height and impossible to resize
  • when creating a new button app, the label says "Default Label" instead of the "Lorem Ipsum" that is default set as its label
  • there is some minimum padding between elements. We should make it 1 or 2 px vertically. Otherwise there is no way to actually use text as a label on tops of items such as table/inputs
  • User input as a runnable input does not retrigger the compute - We should probably remove the visible toggle altogether, it's confusing - static = invisible - connected = invisible - user input = visible I think we should actually just have Static & Connected, and a toggle in Static that allow for User Input

Screenshot 2022-12-28 at 16 54 21

@cloudflare-pages
Copy link

cloudflare-pages bot commented Dec 28, 2022 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a677b7b
Status: ✅  Deploy successful!
Preview URL: https://b1f05ad8.windmill.pages.dev
Branch Preview URL: https://app-bugfix.windmill.pages.dev

View logs

fatonramadani
fatonramadani commented Dec 28, 2022
View reviewed changes
frontend/src/lib/components/apps/editor/GridEditor.svelte Outdated
}
}}
on:pointerup={({ detail }) => selectComponent(detail.id)}
gap={[10, 2]}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rubenfiszel The library exposes a way to configure gaps easily

@rubenfiszel rubenfiszel merged commit fb39565 into main Dec 29, 2022
@rubenfiszel rubenfiszel deleted the app-bugfix branch December 29, 2022 11:47
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rubenfiszel rubenfiszel Awaiting requested review from rubenfiszel rubenfiszel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fatonramadani @rubenfiszel