fix(frontend): Add missing loading state for non-runnable components … #3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…+ fix select and aggrid styling
Deploying windmill with
|
| Latest commit: |
0e2550c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://300b91a1.windmill.pages.dev |
| Branch Preview URL: | https://fr-app-improvements.windmill.pages.dev |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to e859e68 in 1 minute and 39 seconds
More details
- Looked at
207lines of code in7files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_Agxbk1dbPoCejyin
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| <div class={'bg-blue-100 dark:bg-blue-400 transition-all p-1 rounded-component'}> | ||
| <LoaderIcon size={14} class="animate-spin text-blue-800 dark:text-white" /> | ||
| </div> | ||
| <svelte:fragment slot="text"> |
There was a problem hiding this comment.
The slot for text in the Popover component should be named 'content' to match the expected API of the Popover component. This ensures that the text ('Refreshing...' or 'Refresh') is displayed correctly.
Suggested change
| <svelte:fragment slot="text"> | |
| <svelte:fragment slot="content"> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…+ fix select and aggrid styling
Summary:
This PR enhances UI responsiveness and styling across various frontend components, particularly focusing on loading states and visual consistency in dark mode.
Key points:
NonRunnableComponent.svelte.RefreshIndicator.sveltefor visual loading indication.AppSelect.svelteto handle dark mode border color.windmill-theme.css.rx.tsto include unsubscribe functionality.Generated with ❤️ by ellipsis.dev