feat(frontend): improve approval form edition + add a delete button t…

[fatonramadani]

…o the EditableSchema

---

🚀	This description was created by Ellipsis for commit d2378cc

Summary:

Enhanced approval form editing and added a delete button to EditableSchema component in the frontend, including new JSON view toggling functionality.

Key points:

• Enhanced approval form editing with EditableSchemaDrawer and AddProperty components.
• Added delete button to EditableSchemaDrawer to remove schema properties.
• Introduced jsonView state and logic to toggle JSON view for form editing in FlowModuleSuspend.svelte.
• Dispatched change event after deleting an argument in AddProperty.svelte.

---

Generated with ❤️ by ellipsis.dev

[cloudflare-pages]

Deploying windmill with    Cloudflare Pages

Latest commit:	acdeb44
Status:	⚡️  Build in progress...

View logs

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 1806526 in 38 seconds

More details

• Looked at 248 lines of code in 5 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. frontend/src/lib/components/flows/content/FlowModuleScript.svelte:38

• Draft comment:
  The toggleShowAll function correctly toggles the showAllCode state, which is used to conditionally render the code content. This implementation is straightforward and effective for the intended functionality.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The implementation of the toggleShowAll function in FlowModuleScript.svelte is straightforward, toggling the showAllCode boolean state. This state is then used in the template to conditionally render either the full code or a truncated version with a button to show all. The logic seems correct as it directly toggles the state and the UI reacts to this state change to show/hide the full code.

Workflow ID: wflow_P8J8H35SxcJEqG3I

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 564e0d6 in 1 minute and 47 seconds

More details

• Looked at 77 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. frontend/src/lib/components/flows/content/FlowModuleSuspend.svelte:219

• Draft comment:
  The Toggle component for 'JSON View' is always unchecked and disabled, which contradicts the intended functionality of allowing users to toggle JSON view mode. Consider making the checked and disabled properties dynamic based on the appropriate conditions.

<Toggle
	checked={jsonView}
	disabled={!flowModule.suspend}
	label="JSON View"
	size="xs"
	options={{
		right: 'JSON Editor',
		rightTooltip: 'Arguments can be edited either using the wizard, or by editing their JSON Schema.'
	}}
	lightMode
	on:change={() => {
		jsonView = !jsonView;
		if (flowModule.suspend) {
			flowModule.suspend.resume_form = {
				schema: emptySchema()
			}
		}
	}}
/>

• Reason this comment was not posted:
  Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_2uPJLsSVQ9Igu70g

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on d2378cc in 3 minutes and 38 seconds

More details

• Looked at 12 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_Xi6p6W5eDmbe78CR

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.