Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node.js spoonerism service #15

Merged
merged 2 commits into from Sep 7, 2018
Merged

node.js spoonerism service #15

merged 2 commits into from Sep 7, 2018

Conversation

jazzdan
Copy link
Contributor

@jazzdan jazzdan commented Sep 7, 2018

No description provided.

@jazzdan jazzdan requested a review from nicks September 7, 2018 18:40
nicks
nicks reviewed Sep 7, 2018
View reviewed changes
Copy link
Member

@nicks nicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but why would we want to check in the node_modules into git?

they're ignored in the dockerfile, and we never run the build outside the dockerfile

@jazzdan
Copy link
Contributor Author

jazzdan commented Sep 7, 2018

ah my bad, I didn't mean to check it in!

@jazzdan jazzdan merged commit 7c4d563 into master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicks nicks nicks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jazzdan @nicks