Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: log ux improvements #19

Merged
merged 1 commit into from Dec 2, 2019
Merged

spec: log ux improvements #19

merged 1 commit into from Dec 2, 2019

Conversation

nicks
Copy link
Member

@nicks nicks commented Nov 23, 2019

Hello @nicks,

Please review the following commits I made in branch nicks/log:

65ac540 (2019-11-22 22:45:58 -0500)
spec: log ux improvements

@nicks
Copy link
Member Author

nicks commented Nov 23, 2019

this has been floating around internally on the tilt team, just posting in a public place for discussion

Copy link
Contributor

@maiamcc maiamcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicks nicks merged commit d5a8df2 into master Dec 2, 2019
@nicks nicks deleted the nicks/log branch December 2, 2019 17:19
nicks added a commit to tilt-dev/tilt that referenced this pull request Dec 3, 2019
…ervice prefixes

Per tilt-dev/tilt.specs#19, we're moving towards a system
where the engine stores structured logs, and adds the prefixes later.
nicks added a commit to tilt-dev/tilt that referenced this pull request Dec 3, 2019
…ervice prefixes

Per tilt-dev/tilt.specs#19, we're moving towards a system
where the engine stores structured logs, and adds the prefixes later.
nicks added a commit to tilt-dev/tilt that referenced this pull request Dec 4, 2019
…ervice prefixes

Per tilt-dev/tilt.specs#19, we're moving towards a system
where the engine stores structured logs, and adds the prefixes later.
nicks added a commit to tilt-dev/tilt that referenced this pull request Dec 4, 2019
…ervice prefixes (#2621)

Per tilt-dev/tilt.specs#19, we're moving towards a system
where the engine stores structured logs, and adds the prefixes later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants