Fall back to WebBrowser controls when running as admin #250
Conversation
The Edge WebView does not at the time of this writing (28. march 2020) support running in an application with elevated permissions. This commit adds a test to `WebViewControlHost.IsSupported` which checks if the application is running as an administrator so that `WebViewCompatible` will fall back to using the legacy WebBrowser controls. The tests will unfortunately only work when running the test suite as administrator, and that will make all the other tests fail. The test will therefore be marked as inconclusive instead of failling when the test suite is running as a non elevated user so that we won't always have at least one breaking test when we run the test suite.
|
Thanks Andreas-Hjortland for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned 
|
|
|
It would be better if we could support Edge WebView when running as an administrator, but I think this could be a good compromise if that is not possible, or a stopgap solution until we do support running Edge WebView as administrator |
There was a problem hiding this comment.
Thanks so much for this stop-gap measure @Andreas-Hjortland! Sorry for the delay in reviewing this, but I just checked it out with WebViewCompatible on .NET Framework and Core and it worked like a charm and switched to IE 11 mode when running as Admin!
This'll be in the 6.1 release of the toolkit coming in a couple of weeks!
If you have a chance mind updating the documentation file here with this new behavior note? Thanks!
|
Done, you can check it out at MicrosoftDocs/WindowsCommunityToolkitDocs#336 |
Fixes #13
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current behavior is that if you run an application which contains a WebViewCompatible control as administrator the WebViewCompatible controller will not show up (will just be a blank view). See #13 for more details
What is the new behavior?
With this change, the application will fall back to using WebBrowser (legacy) controls when running the application elevated as administrator so that it the views will still work.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Just to reiterate for the new tests to pass, we need to run the test suite as administrator, and that will unfortunately make the other tests fail since WebView does not work when running as administrator.