Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PullToRefreshListView control #1946

Closed
nmetulev opened this issue Apr 6, 2018 · 14 comments
Closed

Deprecate PullToRefreshListView control #1946

nmetulev opened this issue Apr 6, 2018 · 14 comments
Projects
Milestone

Comments

@nmetulev
Copy link
Contributor

nmetulev commented Apr 6, 2018

Once the platform’s native pull-to-refresh control is released, the PullToRefreshListView control will need to be deprecated and leverage the new platform control whenever possible.

We should attempt to add a new property called UseRefreshContainerWhenPossible to enable use of the platform control on devices where it is available.

@nmetulev nmetulev added this to the 3.0 milestone Apr 6, 2018
@nmetulev nmetulev added this to To do in V3.0 via automation Apr 6, 2018
@nmetulev
Copy link
Contributor Author

nmetulev commented Apr 9, 2018

@kbrons is working on this

@nmetulev
Copy link
Contributor Author

PR merged

V3.0 automation moved this from To do to Done Apr 30, 2018
@Trolldemorted
Copy link

@nmetulev If you use a PullToRefreshListView in an UWP project (min build 15063 (Creators Update), target build 17134 (W10 April Update)), you see warnings because of this deprecation:

'PullToRefreshListView' is obsolete: 'The PullToRefreshListView will be removed in a future major release. Please use the RefreshContainer control available in the 1803 version of Windows

Since you refuse to ship any updates beyond 15063 to W10M, UWP developers who don't want to exclude smartphones are stuck with that minimum version. What are we supposed to do with the PullToRefreshListView in the future? Are you serious about removing it?

@nmetulev
Copy link
Contributor Author

nmetulev commented Jul 8, 2018

We are. You can still continue using the PullToRefreshListView by using the source directly (you can find it in our releases), but we will remove it from the nuget packages in the future and we will not fix bugs

@hupo376787
Copy link

Why MS does not consider about our developers' feelings. Change is a good thing, but always change must be bad.

@nmetulev
Copy link
Contributor Author

@hupo376787, it doesn't make sense to support multiple versions of the same functionality. In this case, with the upcoming release of the Windows UI library (which also works on older versions of Windows 10), you can use the RefreshContainer in place of the PullToRefreshListView and we even have a guide on how to do it.

@Trolldemorted
Copy link

@nmetulev does "older versions" include w10 mobile?

@nmetulev
Copy link
Contributor Author

Not sure what their minimum version is, but if it works on Creators Update, then yes.

@hupo376787
Copy link

RefreshContainer's min version is 1803, so the mobile device users will never never get it.

image

@JustinXinLiu
Copy link
Contributor

RefreshContainer will be part of the new Windows UI package which will work on earlier versions of Windows 10.

@hupo376787
Copy link

hupo376787 commented Jul 20, 2018

Following this guide, getting-started.

And according to my test, RefreshContainer can't work on win 10 mobile 15063. I don't have other versions, so the result is not known.

Windows.UI.Xaml.Markup.XamlParseException: 'XAML parsing failed.'

My test project gayhub

@JustinXinLiu
Copy link
Contributor

First, you are not using the control from the nuget at all because you are not setting the target version correctly:

Important: To use the Windows UI Library, your project’s Min version must be 14393 or higher and the Target version must be 17134 or higher.

However, even if you do so, the project will throw the following error:

System.TypeLoadException: 'Could not find Windows Runtime type 'Microsoft.UI.Private.Controls.IRefreshInfoProvider'.'

@nmetulev, could you please let the team know?

@hupo376787
Copy link

Yes, I tried. See my first comment before edited. Same error.

image

@JustinXinLiu
Copy link
Contributor

@hupo376787, no, you cannot just target 16299... If you target 16299, it is still going to use the control in the SDK, NOT the one from the nuget package. You need to make sure the target version is at least 17134.

It will still not work and this is another issue though. We are already looking into this.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
V3.0
  
Done
Development

No branches or pull requests

5 participants