Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Add Analysis for Assembly Sizes #3448

Closed
michael-hawker opened this issue Aug 25, 2020 · 3 comments · Fixed by #3450
Closed

[Testing] Add Analysis for Assembly Sizes #3448

michael-hawker opened this issue Aug 25, 2020 · 3 comments · Fixed by #3450
Assignees
Labels
Milestone

Comments

@michael-hawker
Copy link
Member

Describe the problem this feature would solve

We should have a bot or something output the sizes of the assemblies so we can track changes to our package sizes and dependencies.

Describe the solution

I think the key is to figure out how much any particular package adds to the size of an application. However, dependencies that those packages pull in play a factor as well.

@azchohfi is thinking we'd have a csproj with build flags that would include the different assemblies and a mainpage.toolkit.uwp.ui.controls.xaml to pull in actual usage. Then we'd just build multiple times as part of our CI and could investigate output folder size of the AppX.

@michael-hawker michael-hawker added testing 🏗️ maintenance ⚙️ feature request 📬 A request for new changes to improve functionality labels Aug 25, 2020
@michael-hawker michael-hawker added this to the 7.0 milestone Aug 25, 2020
@ghost
Copy link

ghost commented Aug 25, 2020

Hello, 'michael-hawker! Thanks for submitting a new feature request. I've automatically added a vote 👍 reaction to help get things started. Other community members can vote to help us prioritize this feature in the future!

@azchohfi azchohfi self-assigned this Aug 25, 2020
@ghost ghost added the In-PR 🚀 label Aug 25, 2020
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Nov 10, 2020
@michael-hawker
Copy link
Member Author

michael-hawker commented Nov 10, 2020

@azchohfi the build artifacts are where we can see the size of the end packages, eh? We should add some info to the wiki about how this works and how we can analyze this.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants