Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for installing Windows SDK from ISO #2220

Merged
merged 4 commits into from Jul 11, 2018

Conversation

rjmurillo
Copy link
Contributor

Issue: #

PR Type

What kind of change does this PR introduce?

  • Build or CI related changes

What is the current behavior?

Can't download or use ISO image to install Windows SDK

What is the new behavior?

Script will download the ISO image from a URI, write out the cache information and use HTTP features for cache. If the file is out of date, a new file is downloaded in its place. If the file does not exist, is out of date, or it cannot be determined from the HTTP header, a new file is downloaded. After the file is downloaded the ISO image is mounted, and the installation proceeds. Once finished the ISO is dismounted.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

Script will download the ISO image from a URI, write out the cache information and use HTTP features for cache. If the file is out of date, a new file is downloaded in its place. If the file does not exist, is out of date, or it cannot be determined from the HTTP header, a new file is downloaded.  After the file is downloaded the ISO image is mounted, and the installation proceeds. Once finished the ISO is dismounted.
@clairernovotny
Copy link
Member

@rjmurillo looks like it works based on the successful build step. Adds about 6 minutes to the build, but better than not being able to do it at all :)

The one missing piece is getting an fwlink for the iso's. The current link is generated after login to the insider site and is time-bound. We need something more stable that doesn't require a login.

@rjmurillo
Copy link
Contributor Author

@onovotny Looks good. I'll update #2219 to use 17704

rjmurillo added a commit to rjmurillo/UWPCommunityToolkit that referenced this pull request Jul 10, 2018
Updating to 17704 as installed by CommunityToolkit#2220
@rjmurillo rjmurillo self-assigned this Jul 10, 2018
@nmetulev nmetulev merged commit c0b2af2 into CommunityToolkit:master Jul 11, 2018
@rjmurillo rjmurillo deleted the build/install_iso_sdk branch July 12, 2018 17:59
@rjmurillo rjmurillo restored the build/install_iso_sdk branch July 12, 2018 18:00
@rjmurillo rjmurillo deleted the build/install_iso_sdk branch July 16, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants