Fix issue #2667 TabView on RS3 Resource Missing #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmetulev
approved these changes
Dec 14, 2018
skendrot
approved these changes
Dec 14, 2018
|
Just as a future not I forgot to point out, we missed this as the Sample App defined this resource somewhere (I'm assuming from our WinUI reference) and masked the issue when we ran it on RS3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2667
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Apps using TabView crash on RS3
What is the new behavior?
Removes resource that wasn't used until RS4.
PR Checklist
Please check if your PR fulfills the following requirements:
(https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)