Condense Sample App Categories + Add Subcategories #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmetulev
approved these changes
Feb 12, 2019
|
This PR is linked to unclosed issues. Please check if one of these issues should be closed: #2688 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2688
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Sample app has many categories (12):
Controls category is pretty large (and gets bigger with condensing step done as part of this review):
Search only worked by name:
What is the new behavior?
Condense categories to 8:
Add Subcategories to certain categories to allow for more ordered grouping to aid in searching:
Search looks at name, description and subcategory:
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Adds a new property to the
Sampleobject and modifiessamples.jsonto add it and condense some categories. Adds aCollectionViewSourceand grouping step in the method which retrieves the samples when the menu is opened. Modifies search to look at more fields.Named most of Control categories off of XAML Control Gallery categories. Happy for input on other categories added to Animations and Helpers categories.