New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SampleApp fix. BitmapFileFormat moved assemblies. #3785
Conversation
Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Interesting, I am not noticing an issue with the The existing implementation should allow the function to search threw |
Talked to @azchohfi about this. This may stem from the fact that we had references to Win2D before everywhere across the packages. So what we probably need is both values one for the Uwp.UI.Controls.Media package and one for the Uwp.UI.Media package? |
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this in my local bits for 7.0.0, doesn't hurt, wasn't sure which samples were failing specifically, but no harm in having both.
Fixes Sample App
Sample app was failing to load .bind files that used, for example, the AlphaMode enum.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Using AlphaMode on .bind files doesn't load the sample properly.
What is the new behavior?
Using AlphaMode on .bind files now works.
PR Checklist
Please check if your PR fulfills the following requirements: