Add Style/RedundantSelf

ridgepole · Jun 10, 2018 · 4045385 · 4045385
1 parent 65cfc3b
commit 4045385
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 10 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -89,8 +89,6 @@ Style/PerlBackrefs:
   Enabled: false
 Style/RedundantParentheses:
   Enabled: false
-Style/RedundantSelf:
-  Enabled: false
 Style/RescueStandardError:
   Enabled: false
 Style/Semicolon:

diff --git a/lib/ridgepole/client.rb b/lib/ridgepole/client.rb
@@ -58,7 +58,7 @@ def diff(dsl_or_config1, dsl_or_config2, options = {})
     end
 
     def dump(conn_spec, options = {}, &block)
-      client = self.new(conn_spec, options)
+      client = new(conn_spec, options)
       client.dump(&block)
     end
 

diff --git a/lib/ridgepole/dsl_parser/context.rb b/lib/ridgepole/dsl_parser/context.rb
@@ -10,7 +10,7 @@ def initialize(opts = {})
     end
 
     def self.eval(dsl, opts = {})
-      ctx = self.new(opts)
+      ctx = new(opts)
 
       if opts[:path]
         ctx.instance_eval(dsl, opts[:path])

diff --git a/lib/ridgepole/ext/pp_sort_hash.rb b/lib/ridgepole/ext/pp_sort_hash.rb
@@ -3,7 +3,7 @@ module Ext
     module PpSortHash
       def pretty_print(q)
         q.group(1, '{', '}') do
-          q.seplist(self.sort_by { |k, _| k.to_s } , nil, :each) do |k, v|
+          q.seplist(sort_by { |k, _| k.to_s } , nil, :each) do |k, v|
             v = PpSortHash.extend_if_hash(v)
 
             q.group do

diff --git a/lib/ridgepole/migration_ext.rb b/lib/ridgepole/migration_ext.rb
@@ -13,7 +13,7 @@ def self.record_time
           begin
             self.time_recorder = TimeRecorder.new
             yield
-            result = self.time_recorder.result
+            result = time_recorder.result
           ensure
             self.time_recorder = nil
           end
@@ -25,18 +25,18 @@ def self.record_time
 
     def write(text = '')
       logger = Ridgepole::Logger.instance
-      logger.info(text) unless self.disable_logging
+      logger.info(text) unless disable_logging
       parse_text(text)
     end
 
     def parse_text(text)
-      return unless self.time_recorder
+      return unless time_recorder
 
       case text
       when /\A--\s+(.+)\Z/
-        self.time_recorder.add_key($1)
+        time_recorder.add_key($1)
       when /\A\s+->\s+(\d+\.\d+)s\Z/
-        self.time_recorder.add_value($1.to_f)
+        time_recorder.add_value($1.to_f)
       end
     end