Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TableDefinition#foreign_key #348

Merged
merged 1 commit into from Feb 10, 2021
Merged

Conversation

ksss
Copy link
Contributor

@ksss ksss commented Feb 9, 2021

In Rails6's active_storage:install create this.

# This migration comes from active_storage (originally 20170806125915)
class CreateActiveStorageTables < ActiveRecord::Migration[5.2]
  def change
    create_table :active_storage_blobs do |t|
      t.string   :key,          null: false
      t.string   :filename,     null: false
      t.string   :content_type
      t.text     :metadata
      t.string   :service_name, null: false
      t.bigint   :byte_size,    null: false
      t.string   :checksum,     null: false
      t.datetime :created_at,   null: false

      t.index [ :key ], unique: true
    end

    create_table :active_storage_attachments do |t|
      t.string     :name,     null: false
      t.references :record,   null: false, polymorphic: true, index: false
      t.references :blob,     null: false

      t.datetime :created_at, null: false

      t.index [ :record_type, :record_id, :name, :blob_id ], name: "index_active_storage_attachments_uniqueness", unique: true
      t.foreign_key :active_storage_blobs, column: :blob_id
    end

    create_table :active_storage_variant_records do |t|
      t.belongs_to :blob, null: false, index: false
      t.string :variation_digest, null: false

      t.index %i[ blob_id variation_digest ], name: "index_active_storage_variant_records_uniqueness", unique: true
      t.foreign_key :active_storage_blobs, column: :blob_id
    end
  end
end

I also expect to support t.foreign_key on ridgepole.

@winebarrel
Copy link
Collaborator

Thank you for your PR!
Could you rebase 0.9 head branch?

@ksss
Copy link
Contributor Author

ksss commented Feb 9, 2021

Thanks! Rebased!

@winebarrel
Copy link
Collaborator

Thank you!

@winebarrel winebarrel merged commit 42432c1 into ridgepole:0.9 Feb 10, 2021
@winebarrel
Copy link
Collaborator

v0.9.1 has been released.

@ksss ksss deleted the foreign_key branch February 10, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants