Fix malformed error happened #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winebarrel
reviewed
Aug 25, 2021
lib/ridgepole/delta.rb
Outdated
| @@ -191,7 +191,7 @@ def raise_exception(script, org) | |||
| errmsg = lines.with_index.map do |l, i| | |||
| line_num = i + 1 | |||
| prefix = line_num == err_num ? '* ' : ' ' | |||
| format("#{prefix}%<line_num>#{digit_number}d: #{l}", line_num: line_num) | |||
| format("#{prefix}%<line_num>#{digit_number}d: ", line_num: line_num) + l | |||
There was a problem hiding this comment.
Since using the format function, how about writing the following?
Suggested change
| format("#{prefix}%<line_num>#{digit_number}d: ", line_num: line_num) + l | |
| format("#{prefix}%<line_num>#{digit_number}d: %<line>s", line_num: line_num, line: l) |
There was a problem hiding this comment.
thank you for your advice.
changed 7ca22d4
Pull Request Test Coverage Report for Build 1165307878
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1165351453
💛 - Coveralls |
winebarrel
approved these changes
Aug 25, 2021
|
Thank you! |
|
v0.9.6 has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
malformed format string error happened l of local variables in format method.
ex;
l =
t.column("consumption_tax_rate", :"integer", **{:default=>10, :null=>false, :comment=>"消費税率; 0: 0%\n 5: 5%\n 8: 8%\n 10: 10%"})bundle exec ridgepoleI'm sorry for my bad English.
thanks.