This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
always call the callback and return #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2016
|
@pibi, I tested the new code and I am still getting the issue mccormicka/Mockgoose#204. Do we not need to use something like this? at the end? |
| debug('starting mongokiller.js, ppid:%d\tmongod pid:%d', process.pid, child_pid); | ||
| var killer = proc.spawn("node", [path.join(__dirname, "binjs", "mongokiller.js"), process.pid, child_pid], { | ||
| stdio: 'ignore', | ||
| detached: true | ||
| }); | ||
| killer.unref(); | ||
| } | ||
|
|
||
| callback(child.status); |
There was a problem hiding this comment.
We still need an IF statement to check if the callback is indeed a function.
|
I also required the conditional described by @Amri91. I'm on Windows 10. My build of MERN is broken without this. When will it get merged? |
|
there was a rewrite of this library, so I am closing this pull request. |
t1bb4r
pushed a commit
to t1bb4r/mongodb-prebuilt
that referenced
this pull request
Jul 18, 2018
Fix UnhandledPromiseRejectionWarning error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #12