Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social auth #2

Open
rudimk opened this issue Jun 11, 2015 · 4 comments
Open

Social auth #2

rudimk opened this issue Jun 11, 2015 · 4 comments

Comments

@rudimk
Copy link
Member

rudimk commented Jun 11, 2015

Right now, we've got Twitter auth up and running. Can add Facebook and Google auth too, but does it make sense?

@rudimk rudimk self-assigned this Jun 11, 2015
@vaidik
Copy link

vaidik commented Jun 11, 2015

Add Github as well

@rudimk
Copy link
Member Author

rudimk commented Aug 27, 2015

Yes, definitely. Facebook, Twitter, Github.

Deferring this for now, since I'm exploring other ways to revamp notCRUD. The next version will feature social auth and maybe better social stories.

@rudimk rudimk added this to the V2 milestone Aug 27, 2015
@rudimk rudimk added the wontfix label Oct 29, 2015
@rudimk
Copy link
Member Author

rudimk commented Oct 29, 2015

Right now, it's going to be a massive pain - if existing users sign in with their social creds, won't be able to connect the two accounts together. Deferring for now.

@rudimk
Copy link
Member Author

rudimk commented Oct 29, 2015

Well, turns out an association can be made, if the social auth account's email address is the same as the one used for the notCRUD account. Could ask users to make sure if they use SSO, the two emails match. Duplicate accounts will turn up anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants