Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End of Episode #4

Open
oroojlooy opened this issue Mar 4, 2020 · 2 comments
Open

End of Episode #4

oroojlooy opened this issue Mar 4, 2020 · 2 comments

Comments

@oroojlooy
Copy link

Right now when I run an episode, it does not stop and just runs forever, since the following function is not implemented:

def _check_episode_done(self, list_state):

    # ======== to implement ========

    return False

Couple of questions:
1- What episode's stopping condition did you use in the paper?
2- How does the environment uses the traffic-flow file? Does it go to the first of the traffic-flow file at every time that I hit env.reset()?
I am asking this, since if I force the episode to stop at a given simulation time (the output of env.get_current_time()), the returned state by env.reset() is always a vector of zeros.

@wingsweihua
Copy link
Owner

  1. Stopping condition is the total simulation time, specified in arg.cnt .
  2. This correlates with the CityFlow simulator. Env.reset() will basically reload the traffic flow file (or reset the system state, including the simulation time and the traffic flow)

@oroojlooy
Copy link
Author

I see that it controls dic_exp_conf["RUN_COUNTS"] in the generator function, but still the env does not return done=True. Does it harm if I modify def _check_episode_done(self, list_state):?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants