Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible bug in bindingListWatch #3

Closed
rigdern opened this issue Jul 1, 2015 · 1 comment
Closed

Possible bug in bindingListWatch #3

rigdern opened this issue Jul 1, 2015 · 1 comment
Assignees
@yildirimcagri-msft
Labels
.kind: codebug ..pri: 1
Milestone
1507

Comments

@rigdern
Copy link

rigdern commented Jul 1, 2015

I noticed that bindingListWatch was modified in the version of knockout-winjs used in the CharMap //build demo:

https://github.com/MicrosoftEdge/CharMap/blob/master/js/lib/knockout-winjs.js

If you diff that file with the initial check in of knockout-winjs in this repo, you'll see there are a few differences:

image

We should investigate why those changes were made and make a fix in this repo if needed.
@jdalton jdalton added this to the 1507 milestone Jul 7, 2015
@jdalton jdalton modified the milestones: 1506, 1507 Jul 7, 2015
@jayrenn jayrenn modified the milestones: 1506, 1507 Jul 14, 2015
@yildirimcagri-msft
Copy link
Contributor

Fixed with fbdbe4f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yildirimcagri-msft yildirimcagri-msft

Labels
.kind: codebug ..pri: 1
Projects
None yet
Milestone
1507
Development

No branches or pull requests
4 participants
@jdalton @rigdern @yildirimcagri-msft @jayrenn