Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider lowercase letters for the Gamepad enum keys #1435

Closed
payzer opened this issue Sep 2, 2015 · 3 comments
Closed

Consider lowercase letters for the Gamepad enum keys #1435

payzer opened this issue Sep 2, 2015 · 3 comments

Comments

@payzer
Copy link
Contributor

payzer commented Sep 2, 2015

The keys defined in _ElementUtilities.js for the gamepad have an uppercase 'G'.

It'd be ideal if those keys used lowercase 'g's to be consistent with the rest of the enumeration and apps that may have coded to a version of the enum with a lowercase.

@jseanxu
Copy link
Contributor

jseanxu commented Sep 3, 2015

This would be technically a breaking change which we wouldn't take until the next major release of WinJS.

@mikewjackson mikewjackson modified the milestones: 1509, Future Sep 29, 2015
@jdalton jdalton added the stale label Oct 8, 2015
@jdalton jdalton closed this as completed Oct 8, 2015
@payzer
Copy link
Contributor Author

payzer commented Oct 8, 2015

I'm going to re-activate this since it looks from the history it only got closed because it was "stale"

@jdalton
Copy link
Contributor

jdalton commented Oct 8, 2015

Hi @payzer! Because this is a pri 2 and would be a breaking change you can consider this a won't fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants