-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jQuery 2.2.0 and smooth scrolling selector #135
Labels
Comments
Could you show your revised code, I've got the same issue, and had to roll back jquery version. |
change the above line to this $("[data-scroll='smooth'] a[href*='#']:not([href='#'])").on('click', function() { |
@jasonaken Oh yeah. Now it doesnt throw error with jQuery v2.2.0 Thanks |
@jasonaken, thanks for the fix! This change will be included in the next release. |
very nice |
Fixed, #137. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jquery/jquery@86e62d8
the above commit broke the selector in app.js on this line. Adding the quotes seems to take care of the issue.
$('[data-scroll="smooth"] a[href*=#]:not([href=#])').on('click', function () {
The text was updated successfully, but these errors were encountered: