Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery 2.2.0 and smooth scrolling selector #135

Closed
Akenator opened this issue Feb 1, 2016 · 6 comments
Closed

jQuery 2.2.0 and smooth scrolling selector #135

Akenator opened this issue Feb 1, 2016 · 6 comments
Labels

Comments

@Akenator
Copy link

Akenator commented Feb 1, 2016

jquery/jquery@86e62d8

the above commit broke the selector in app.js on this line. Adding the quotes seems to take care of the issue.

$('[data-scroll="smooth"] a[href*=#]:not([href=#])').on('click', function () {

@englishextra
Copy link

Could you show your revised code, I've got the same issue, and had to roll back jquery version.

@Akenator
Copy link
Author

Akenator commented Feb 1, 2016

change the above line to this

$("[data-scroll='smooth'] a[href*='#']:not([href='#'])").on('click', function() {

@englishextra
Copy link

@jasonaken Oh yeah. Now it doesnt throw error with jQuery v2.2.0

Thanks

@mlijanto
Copy link
Contributor

mlijanto commented Feb 2, 2016

@jasonaken, thanks for the fix! This change will be included in the next release.

@mlijanto mlijanto added the bug label Feb 2, 2016
@englishextra
Copy link

very nice

@mlijanto
Copy link
Contributor

mlijanto commented Feb 5, 2016

Fixed, #137.

@mlijanto mlijanto closed this as completed Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants