Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows 10] no graphs in sysinformation Window shown in Tabletmode #40

Closed
MagicAndre1981 opened this issue May 1, 2016 · 12 comments
Closed
Assignees
Labels

Comments

@MagicAndre1981
Copy link
Contributor

When I run Windows 10 in Tabletmode, start ProcessHacker, no graphs are shown in systeminformation window and at closing the Window, PH crashes at VOID PhSipOnNcDestroy (sysinfo.c line 334)

for (i = 0; i < SectionList->Count; i++)

@dmex dmex added the bug label May 1, 2016
@dmex dmex assigned wj32 May 1, 2016
@dmex
Copy link
Member

dmex commented May 1, 2016

Have you tried any nightly releases?

I can reproduce this in 2.39 stable. Repo steps:

  1. Click the Action center icon in the system tray (right next to the clock).
  2. Click the Tabet Mode button.
  3. Open Process Hacker and open the System Information window.

The window is blank and closing the window causes a crash.

@MagicAndre1981
Copy link
Contributor Author

I run the latest nightly (32Bit) compiled on my own with Vs2015 Upd2

@tigros
Copy link

tigros commented May 2, 2016

problem is no WM_SHOWWINDOW message sent to PhSipSysInfoDialogProc in sysinfo.c.

if you move PhSipOnShowWindow(...) to WM_INITDIALOG it works, take it or leave it :)

@dmex
Copy link
Member

dmex commented May 2, 2016

Tablet mode should really be sending the WM_SHOWWINDOW message since there are likely thousands of other applications that will have similar issues.

@MagicAndre1981
Copy link
Contributor Author

ok, I've asked Microsoft and I got the answer, that it is by design, that the Tablet mode doesn't send WM_SHOWWINDOW message. So move it to WM_INITDIALOG. Here it works for me as @tigros figured out.

@wj32
Copy link
Contributor

wj32 commented May 6, 2016

@MagicAndre1981 Did they tell you why it's "by design"?

@MagicAndre1981
Copy link
Contributor Author

nope, only that it is by design.

@MagicAndre1981
Copy link
Contributor Author

this quote was highlighted:

When a top-level, overlapped window is created with the WS_MAXIMIZE

so Tablet mode seams to activate this.

@tigros
Copy link

tigros commented May 6, 2016

out of curiosity i looked up what reactos is doing, so for all the dirty details go to line 2426 of https://doxygen.reactos.org/d0/dcd/ntuser_2winpos_8c_source.html

cheers!

@MagicAndre1981
Copy link
Contributor Author

@wj32 any update one this? What are your plans to fix it?

@wj32
Copy link
Contributor

wj32 commented May 8, 2016

I'll fix it when I have time

@dmex dmex added this to the Future milestone May 13, 2016
@MagicAndre1981
Copy link
Contributor Author

@dmex

can you please add the fix from @tigros ?

@dmex dmex closed this as completed in 9430ac9 Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants