Q: can it work with scss preprocess?

[Valexr]

<style lang="scss">

[winston0410]

I think so, but you have to place this preprocessor after scss preprocessor, as this one only handles vanilla CSS.

[Valexr]

Ok🤓will try it

[winston0410]

@Valexr Do let me know if there is any bug!:)

[Valexr]

Yep, I have a bug with <style lang=scss> with esbuild-svelte plugin:

testing repo

[winston0410]

@Valexr thank you for the testing repo! I will use it and see how can I fix that.

[Valexr]

But I'm haven't testings with other bundlers... like rollup or webpack

[winston0410]

@Valexr It will work if you use a wrapper like this: winston0410/svelte-glory@f8744a3

As explained here: https://www.npmjs.com/package/svelte-as-markup-preprocessor

Btw I would be great if you can help out making a benchmark repo:)

[Valexr]

preprocess is not defined 🤷🏻‍♂️

[winston0410]

Sorry it should be this: winston0410/svelte-glory@4715e88

Good catch!

[Valexr]

It's building now, but missing inherited class in element <h1 class>

[winston0410]

@Valexr good catch, let me check it again

[winston0410]

@Valexr It was the issue with descendant combinators. Fixed in 227a0bb

[Valexr]

Sorry, but in 0.1.9 one more error

🤷🏻‍♂️

[Valexr]

v 0.2.0 still error

[winston0410]

I have just refactored to support more selectors, and I guess I will take a few more day to fix it and make it usable again.

[Valexr]

It's ok🤓just trying help you with SASS preprocessing testing, if you need this exactly

[winston0410]

Yes please do! Any testing is helpful:)

[winston0410]

@Valexr I think I have fixed all previously mentioned issue in 0.2.2, maybe you can give it a try now.

winston0410/svelte-glory@a847cf9

[Valexr]

Yep👍🏻working 👌🏻

[Valexr]

But in more complicated project with CSS & SCSS together:

<style lang="scss" global>
  @import "base.scss"
</style>

// or

<style src="variables.css"></style>

I have a bug

while don't understand with what...

[Valexr]

Update testing repo with global attribute no bugs but broken styles

[winston0410]

@Valexr For the error message, the issue is in esbuild itself, which I guess it doesn't pass the log back from worker thread to the thread used in Node. I will look at the error again tomorrow.

[winston0410]

@Valexr seems like it is working now, can you give it a try?
https://github.com/winston0410/svelte-glory

Btw is there any documentation for using src in <style> in svelte? I cannot find it.

[Valexr]

Yep, it's working, but add whitespaces

with glory

without

[winston0410]

@Valexr Can you find out what class is added/missing there between two version?

[Valexr]

Wrong info about whitespases, sorry...
Missing @media query

[winston0410]

Right it is media query, and I have fixed it this morning.Maybe you can give it a try again now? (install from github instead of npmm it is breaking a lot right so I guess I wont publish on npm untill bug free)

[Valexr]

Ok. What true link from GitHub?

with this link same issue - missed @media-query:

"dependencies": {
    "glory-svelte-preprocess": "github:winston0410/glory-svelte-preprocess"
}