New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log files are rotated every minute even if datePattern specifies only daily rotation #40

Closed

kumar-b opened this issue Jun 4, 2016 · 1 comment

kumar-b commented Jun 4, 2016

Even if the pattern is '.yyyy-MM-dd', the log files are rotated based on minutes. The new stream (self._createStream()) are opened even when the log files are one minute older (this._minute < now.getUTCMinutes()). https://github.com/winstonjs/winston-daily-rotate-file/blob/master/index.js#L395 . Also attempt to open next appropriate file also called each one minute and self._created is set to 0 every minute. https://github.com/winstonjs/winston-daily-rotate-file/blob/master/index.js#L551

I think the new stream creation should happen based on given pattern.

Member

mattberther commented Jun 13, 2016

Resolved by a07b820.

mattberther closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment