Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winston loses Map and Set properties on meta #1054

Closed
robotmayo opened this issue Aug 10, 2017 · 2 comments
Closed

Winston loses Map and Set properties on meta #1054

robotmayo opened this issue Aug 10, 2017 · 2 comments
Assignees
Labels
Metadata Applies to Metadata behavior Needs Investigation

Comments

@robotmayo
Copy link

Example:

const myMeta = {istay: "a", iWillDissapear: new Map([["a","b"]])
winston.log("Some text", meta);
// outputs => Some Text {istay:"a", iWillDissapear: {}}

The cycle library as well as clone do not properly support maps and sets. Id recommend using lodash.clone or lodash.cloneDeep.

@maverick1872
Copy link
Member

Introduced tests verifying this behavior functions as one would expect here: c4dd5ea

@maverick1872
Copy link
Member

As it stands right now these tests are passing in the latest version as the tests above are defined. As such I'll be closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metadata Applies to Metadata behavior Needs Investigation
Projects
None yet
Development

No branches or pull requests

2 participants