Property "tailable: true" is not working as declared for winston File Transport

[mikrivorot]

Environment:

• winston@3
• node -v : v8.6.0 and v10.7.0
• Operating System : Windows
• Language ES6

Problem:
I am using File winston transport in this way:

const fileTransport = new transports.File({
        filename: 'log.out',
        level: 'debug',
        maxsize: 100*1024, // 10 MB
        maxFiles: 3,
        json: false,
        tailable: true
    });

const logger = winston.createLogger({
    level: 'debug',
    format: combine(formatFile),
    transports: fileTransport,
    handleExceptions: true
});

File 'log.out' is created in necessary directory, but after the maxsize reached, logging is stopped, it means no files created.
But in 'tailable' property description "If true, log files will be rolled based on maxsize and maxfiles, but in ascending order. The filename will always have the most recent log lines. The larger the appended number, the older the log file"

I think, problem is that code of creating new and renaming old log files is unreachable:
from

winston/lib/winston/transports/file.js

Line 600 in a32aa3c

let fileName = `${basename}${(i - 1)}${ext}${isZipped}`;

till

winston/lib/winston/transports/file.js

Line 609 in a32aa3c

fs.rename(tmppath, path.join(this.dirname, fileName), cb);

due to internal error in asyncSeries() function:

winston/lib/winston/transports/file.js

Line 615 in a32aa3c

asyncSeries(tasks, () => {

winston/lib/winston/transports/file.js

Line 12 in a32aa3c

const asyncSeries = require('async/series');

and this code is also unreachable:

winston/lib/winston/transports/file.js

Line 617 in a32aa3c

path.join(this.dirname, `${basename}${ext}`),

(only in case "maxFiles: 1", then tasks array is empty)

Similiar Github issues:
#589
winstonjs/winston-daily-rotate-file#23 ("still doesn't work with winston@2.4.1")
#1264

[DABH]

This may have just been fixed via merging #1420. Any chance you could give this a try using master, and seeing whether this works for you now? Thanks!

[jaxer]

I can confirm that tailable is broken in 3.0.0 and fixed in master.

[DABH]

Sweet. We will be publishing a 3.x update to npm very soon!

[mikrivorot]

Hi everyone!
Thank you for your fix!

I tested this fix and I have some results:

• tailable parameter works in the way it is declared. It creates log files in ascending mode.

• but during the logging some log entries are placed in wrong log files or missed at all, and I am planning to provide examples for this case and found place in code, where the error occurred.

[DABH]

That would be great. If you figure out how to fix any errors in the code, that would be especially appreciated (feel free to open a PR!). Probably best to open a new issue if you find different errors in the code. Thanks again!

[DABH]

Closing this one for now since we got v3.1.0 published!