Allowing use of both meta and splat in same call to log()

[mpabst]

The arguments.length > 2 section in log() examines the first item in the splat param to see if it's a meta object. Problem is, a subsequent call to splat.slice() still includes that meta object in the splat, accidentally calling slice(0) instead of slice(1).

Here's an example that breaks under the merge target but works when using the merge source:

const winston = require('winston');

let transports = {
  console: new winston.transports.Console({level: 'info'})
};

let {format} = winston;
let logger = winston.createLogger({
  format: format.combine(
    format.splat(),
    format.printf(info => `[${info.label}]: ${info.message}`)
  ),
  transports: [transports.console]
});

logger.log(
  'info',
  'let\'s %s some %s',
  {label: 'label!'},
  'interpolate',
  'splat parameters'
);

[mpabst]

Here you go @DABH – I just went and created a new PR, as you can see. Thanks for checking this out!

[DABH]

Thanks for the example, that helps clarify things! :) I took a look and this really seems like a silly bug (why would you call splat.slice(0) and not just splat? clearly the intent was to remove meta from splat, hence should be splat.slice(1)). Going to merge this, and it should land in the next release in about a week! Thanks again for your patience and contribution!

[mpabst]

Great, thanks again for doing so much for this project! 😊🙌

[DABH]

Actually this seems problematic -- I can no longer log a single object as a splat:
logger.info('hey %O', obj);
doesn't format the splat right anymore...

[DABH]

@mpabst how would you feel about putting your extra meta objects after your other splats? I feel like that is more logical and the way it may have been intended to work... would love your feedback on
#1499
winstonjs/logform#57
! Thanks!

[mpabst]

Hey! Sorry for the late reply, but that should be totally fine. It’s just a reordering of those parameters to log(), right? Thanks again!

…

On Oct 9, 2018, at 15:43, DABH ***@***.***> wrote: @mpabst <https://github.com/mpabst> how would you feel about putting your extra meta objects after your other splats? I feel like that is more logical and the way it may have been intended to work... would love your feedback on #1499 <#1499> winstonjs/logform#57 <winstonjs/logform#57> ! Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1485 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAL12J0MoQC0k9Pssd_0SBKmgs2TFuFrks5ujQp-gaJpZM4XAPgL>.