Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try better fix for #1485 #1499

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Try better fix for #1485 #1499

merged 1 commit into from
Dec 7, 2018

Conversation

DABH
Copy link
Contributor

@DABH DABH commented Oct 9, 2018

@DABH DABH requested a review from indexzero October 9, 2018 20:42
@DABH DABH mentioned this pull request Oct 9, 2018
Merged
@DABH DABH added the Important label Oct 9, 2018
@GeekyDeaks
Copy link

I think this is the right way to go regarding the [SPLAT] contents, however IMHO it's still premature to make assumptions about meta at this stage and should really be done after the splat parsing has completed

@indexzero indexzero merged commit 785ea22 into master Dec 7, 2018
@indexzero indexzero deleted the retry-1485 branch December 7, 2018 21:53
@DABH DABH added this to In progress in winston@3.2.0 Dec 13, 2018
@DABH DABH moved this from In progress to Done in winston@3.2.0 Dec 23, 2018
@indexzero indexzero mentioned this pull request Dec 23, 2018
Merged
Mizumaki pushed a commit to Mizumaki/winston that referenced this pull request Jun 11, 2020
@DABH @indexzero
Try better fix for winstonjs#1485 (winstonjs#1499)
e99a42d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indexzero indexzero indexzero approved these changes

Assignees
No one assigned
Labels
Important
Projects
No open projects
winston@3.2.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DABH @GeekyDeaks @indexzero