Log file without .gz for tailable (#1525) #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Convert vows based file-archive-test * Do not append .gz to log file if tailable and zippedArchive are true
|
Thanks for the PR! Sorry for delay in taking a look. Does the test actually catch the case you fixed? I.e. does the test fail on master and pass on your branch? If so then should be good to merge, I just want to ensure the test coverage is there :) Let me know! |
|
Yes the test fails on master (just tested again, with current master), it is running into the 2000ms timeout. The test calls |
|
Cool, thanks for checking! Going to go ahead and hit merge -- hopefully this is the last of these tailable issues, but let's see... thanks again |
Mizumaki
pushed a commit
to Mizumaki/winston
that referenced
this pull request
Jun 11, 2020
* Log file without .gz for tailable (winstonjs#1525) * Convert vows based file-archive-test * Do not append .gz to log file if tailable and zippedArchive are true * Fix file-archive.test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1525