Alternative fix for #1501

[indexzero]

@pahan35 interested in your thoughts. Your fix could also work, but this one is more performant.
Assuming implicit argument values is also quite dangerous, but since the level helper methods (e.g. logger.silly('wat ok')) were created to be a little magical it seems reasonable to assume that these two statements are equivalent:

logger.silly();
logger.silly('');

Where our fixes differ is that this behavior will still crash someone's program:

logger.log('silly');

It would crash because the log method is not being invoked with the correct number of arguments – which avoids having to add additional variable-arity or type checking into the core log method hot path.

If there are no objections will add some tests for this and push it out in the next release.

[pahan35]

I guess we can prevent multiple return by

if (args.length === 0) {
  args.push('')
}

IMHO problem with direct log without a msg

logger.log('silly');

can be omitted, cause we have msg as a required parameter in the method declaration

[indexzero]

Glad you agree with me about logger.log('silly').

W.r.t. your comment regarding multiple returns – returning early is faster than appending to an array. Performance is the most important aspect of these helper methods. If the code is slightly more verbose that's not as much of an issue. These methods will get invoked dozens or hundreds of times per second in a typical web server so every nanosecond counts.

[pahan35]

@indexzero thanks for your explaining about performance.

Waiting for your fix in the published to npm version.

[indexzero]

Once we get a test for this we can land it and publish.

[pahan35]

@indexzero any updates?

[indexzero]

Sorry this got overlooked in winston@3.2.0. Will make sure it gets into a patch release soon.