add bearer auth capabilities to http transport; #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
has some connection to #1020 |
… 6 compatibility;
DABH
reviewed
Jun 29, 2019
DABH
reviewed
Jun 29, 2019
DABH
requested changes
Jun 29, 2019
Merge in master source
|
One other thing i can improve is the typescript definition to force the developer to use either bearer or basic. right now both could be filled in and result in some oddities. |
|
I think if both are set then it's more or less user error. One could imagine some weird backends too where you'd want that flexibility. So I think this PR is good to go as-is. Thanks for your patience! |
DABH
approved these changes
Aug 15, 2019
yinzara
added a commit
to yinzara/winston
that referenced
this pull request
Oct 4, 2019
yinzara
added a commit
to yinzara/winston
that referenced
this pull request
Oct 5, 2019
Mizumaki
pushed a commit
to Mizumaki/winston
that referenced
this pull request
Jun 11, 2020
* add bearer auth capabilities to http transport; * replace headers clone via spread operator with Object.assign for node 6 compatibility;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.