Http Transport uses JSON format options as request options

[MoritzLoewenstein]

Please tell us about your environment:

• winston version?
  • winston@2
  • winston@3
• _node -v outputs: v13.1.0
• _Operating System? windows & linux same behaviour
• _Language? -

What is the problem?

If I use a property in a JSON formatted log which has the same name as an option in the configuration of the Http Transport its used as an option there (See Example Code).

What do you expect to happen instead?

I do expect that the contents of <logger>.log() directly go the logging transport and do not interfere with the transport configuration.

Example Code

const winston = require("winston");
const express = require("express");

const app = express();

app.post("/a", (req, res) => {
  console.log("This is good");
});

app.post("/b", (req, res) => {
  console.log("This is bad");
});

app.listen(80, console.log("Server started"));

const logger = winston.createLogger({
  format: winston.format.json(),
  transports: [
    new winston.transports.Http({
      host: "localhost",
      path: "/a"
    })
  ]
});

logger.log({ message: "abc", level: "info", path: "/b" });

Example Code Output

Server started
This is bad

[meyer9]

also running into this issue... seems to be something wrong here: https://github.com/winstonjs/winston/blob/master/lib/winston/transports/http.js#L182-L183

[DABH]

PR is welcomed, if you identify a bug and can include some unit tests in a PR!

[MoritzLoewenstein]

I opened a PR, i dont think its perfect but it fixes the issue as far as I can tell @DABH

[DABH]

Going to close this issue since we've merged the PR (this fix will go out in the next release, which should probably be a minor release 3.2.0). Thanks for your contribution!