defaultMeta ignored when using logger.log function but not in logger[level] functions

[FranciscoG]

Please tell us about your environment:

• winston version?
  • winston@2
  • winston@3 3.2.1
• node -v outputs: v13.5.0
• Operating System? (Windows, macOS, or Linux) macOS
• Language? (all | TypeScript X.X | ES6/7 | ES5 | Dart) ES6/7

What is the problem?

When calling the function logger.log('debug', 'message') it seems to completely ignore defaultMeta, but calling functions like logger.debug does not

My createLogger

const logger = winston.createLogger({
  level: "debug",
  defaultMeta: { id: 'APP' },
  format: winston.format.combine(
    winston.format.colorize(),
    winston.format.timestamp({
      format: "YYYY-MM-DD h:mm:ss:SSS"
    }),
    winston.format.printf(
      info => `${info.timestamp} ${info.level}: [${info.id}] ${info.message}`
    )
  ),
  transports: [new winston.transports.Console()]
});

What do you expect to happen instead?

Given my createLogger setup above I expect both

logger.info("This is my info")

AND

logger.log("info", "This is my info")

to both print out this to the console:

2020-02-04 11:30:34:313 info: [APP] This is my info

However the latter (logger.log) prints this

2020-02-04 11:30:34:307 info: [undefined] Initializing web sockets  

Other information

[alvinalexander]

I ran into the same issue. I believe this issue is related to this line:

winston/lib/winston/logger.js

Line 223 in 73ae01f

this.write({ [LEVEL]: level, level, message: msg });

[IzaacJ]

I have the same issue.
winston version: 3.3.3
node version: 16.2.0
Operating System? Windows 10 20H2
Language? TypeScript 4.3.2

[peey]

I'm not a contributor but was browsing the code related to another issue.

68ea786 (#1712) seems to fix exactly this issue. Could someone check if it's still present on the latest winston version? and if it's not then this may be closed.

[Faithfinder]

Still the same on 3.3.3

[abarke]

Using 3.3.3 we get the following...

const logger = winston.createLogger({
  level: "debug",
  defaultMeta: {
    meta: {
      client: { name, version }
    }
  },
  transports: [new winston.transports.Console()]
});

logger.log('error', 'Error message');
// {"level":"error","message":"Error message"}

logger.error('Error message');
// {"level":"error","message":"Error message","meta":{"client":{"name":"james-bond","version":"0.0.7"}}}

[gioamato]

Same happening with profiling, the logger.profile() method ignores defaultMeta.

So is this actually an issue or the expected behavior?

[maverick1872]

Possibly related to #2029

[maverick1872]

Introduced the above example as a test case in #1989 and have verified this is functioning as we would expect. As such I will be closing this issue and letting the master issue track this issue.